Skip to content

Conversation

@patrickfreed
Copy link
Contributor

This is the second in a series of PR's for implementing the retryable writes spec tests and updating our test runner framework.

This PR updates the test utils to be more usable for the new runner.
In total:

  • moves ServerVersion out of a client extension such that it is its own type
  • adds Comparable conformance to ServerVersion so we don't need to implement/use the various isGreaterThan, isLessThan, etc. methods
  • adds an initializer to TopologyType for use in testing
  • adds an internal sortedEquals method to a Document extension for testing purposes (so we don't need to use an expect to get sorted equality)
  • moves the WriteModel typealiases into TestUtils.swift

…ut of client extension, add sortedEquals to Document, move model typealiases

(cherry picked from commit de9662a1653e971c082687f23e3d0df5678413ae)
@patrickfreed patrickfreed requested review from kmahar and mbroadst May 21, 2019 20:27
@patrickfreed patrickfreed merged commit ac2adb7 into master May 23, 2019
@patrickfreed patrickfreed deleted the SWIFT-178/retryable-writes-test-utils branch May 23, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants